Open
Conversation
loafoe
force-pushed
the
chore/golangci-migrate
branch
from
9152b94 to
07fa96b
Compare
loafoe
changed the title
Author
|
@sagikazarmark possible to review this one? |
cardoe
reviewed
Aug 3, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
Seems reasonable to at least trigger the CI on this one.
Member
|
@loafoe thanks for the PR. Would you mind rebasing and applying your fixes to the latest master? We've updated the linter with the Go version. |
loafoe
force-pushed
the
chore/golangci-migrate
branch
from
07fa96b to
9d18274
Compare
loafoe
changed the title
Author
|
@sagikazarmark rebased to |
cardoe
approved these changes
Aug 19, 2025
sagikazarmark
added
the
release-note/ignore
sagikazarmark
approved these changes
Aug 19, 2025
loafoe
force-pushed
the
chore/golangci-migrate
branch
from
9d18274 to
fdc2371
Compare
Author
|
@sagikazarmark @cardoe FYI rebased to |
cardoe
approved these changes
Oct 6, 2025
Contributor
|
@loafoe it failed tests |
loafoe
force-pushed
the
chore/golangci-migrate
branch
from
fdc2371 to
dea90b8
Compare
Author
|
@cardoe possible to retrigger the tests so I can verify tests are fixed? |
Member
|
I triggered the tests, but they are still failing. Looks like something related to the Kubernetes storage. |
Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
loafoe
force-pushed
the
chore/golangci-migrate
branch
from
dea90b8 to
72dd3b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade golangci to 2.4.0 and fix the newly found issues.
What this PR does / why we need it
Use a more recent linter
Special notes for your reviewer